Update ContactsList.swift#11
Open
JCKL wants to merge 1 commit into
Open
Conversation
When adding fields to Contact, the original implementation didn't guarantee updates when additional fields were added to Contact unless the additional fields were also added here which gets very clunky. I think a better approach is to make the listID by combining self.id with self.userModificationDate. This guarantees updates when new fields are added to Contact and I think is a better pattern for developers to implement going forward.
Aztekqueen86
approved these changes
Apr 6, 2024
Aztekqueen86
approved these changes
Apr 6, 2024
Aztekqueen86
approved these changes
Apr 9, 2024
|
I think the reason for the lack of updates is a mistake that It is a bad idea to name Views using model names too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding fields to Contact, the original implementation of listID didn't guarantee updates when additional fields were added to Contact unless the new fields were also added here which gets very clunky.
I think a better approach is to make the listID by combining self.id with self.userModificationDate.
This guarantees updates when new fields are added to Contact and I think is a better pattern for developers to implement in their own projects.